Fix: Gradient picker bug onToggle #21732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Bug
jorgefilipecosta
requested review from
ajitbohra,
chrisvanpatten and
youknowriad
as code owners
|
Size Change: +11 B (0%) Total Size: 842 kB
ℹ️ View Unchanged
|
jorgefilipecosta
deleted the
fix/custom-gradient-picker-stops-working-after-a-double-click-on-control-point
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The custom gradient picker stops working after a double click on a control point. This PR fixes the issue by adding a case to the control point-click events that check if the control point popover is already open.
Fixes: #20779
How has this been tested?
I repeated the steps described in #20779 and verified the bug does not happen anymore.